added scales #128
Closed
added scales #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closes #119 |
djdiskmachine
requested changes
Sep 30, 2024
| @@ -27,6 +28,11 @@ tempoNudge_(0) | |||
| this->Insert(wrap) ; | |||
| Variable *transpose=new Variable("transpose",VAR_TRANSPOSE,0) ; | |||
| this->Insert(transpose) ; | |||
|
|
|||
| // from: https://github.com/xiphonics/picoTracker/blob/master/sources/Application/Model/Project.cpp | |||
There was a problem hiding this comment.
I'd prefer if we keep this info in the corresponding .h and .cpp, it's not necessary to have it here.
| @@ -59,6 +65,13 @@ Project::~Project() { | |||
| delete instrumentBank_ ; | |||
| } ; | |||
|
|
|||
| // from: https://github.com/xiphonics/picoTracker/blob/master/sources/Application/Model/Project.cpp | |||
There was a problem hiding this comment.
I'd prefer if we keep this info in the corresponding .h and .cpp, it's not necessary to have it here.
| @@ -206,6 +207,12 @@ void PhraseView::updateCursorValue(ViewUpdateDirection direction,int xOffset,int | |||
| } | |||
| if ((c)&&(*c!=0xFF)) { | |||
| int offset=offsets_[col_+xOffset][direction] ; | |||
| // from: https://github.com/xiphonics/picoTracker/blob/master/sources/Application/Views/PhraseView.cpp | |||
There was a problem hiding this comment.
I'd prefer if we keep this info in the corresponding .h and .cpp, it's not necessary to have it here.
| @@ -1178,6 +1186,27 @@ void PhraseView::DrawView() { | |||
|
|
|||
| drawMap() ; | |||
| drawNotes() ; | |||
|
|
|||
| // Draw Current Scale | |||
There was a problem hiding this comment.
Please no commits containing commented-out code
| @@ -114,6 +115,17 @@ ProjectView::ProjectView(GUIWindow &w,ViewData *data):FieldView(w,data) { | |||
| position._y+=1 ; | |||
| UIIntVarField *f2=new UIIntVarField(position,*v,"transpose: %3.2d",-48,48,0x1,0xC) ; | |||
| T_SimpleList<UIField>::Insert(f2) ; | |||
|
|
|||
| // from: https://github.com/xiphonics/picoTracker/blob/master/sources/Application/Views/ProjectView.cpp | |||
There was a problem hiding this comment.
I'd prefer if we keep this info in the corresponding .h and .cpp, it's not necessary to have it here.
Closed
|
Closed in #157 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on xiphonics/picoTracker#39