Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the datalink #doi entry #225

Merged
merged 8 commits into from
Dec 21, 2023
Merged

Fix the datalink #doi entry #225

merged 8 commits into from
Dec 21, 2023

Conversation

kimakan
Copy link
Contributor

@kimakan kimakan commented Dec 18, 2023

This PR changes the description of the datalink entruies with the semantic #doi. Instead of The Digital Object Identifier for the ..., it will use the title of the table/schema obtained from the metadata. It is clear that it refers to the DOI of the given object due to the used semantic #doi anyway, thus the explicit mentioning of the DOI in the description is obsolete.
This change is due to the fact that the OAI-PMH interface uses the description of the #doi entry as title for the OAI record. It's wrong since the OAI record refers to the object itself and not to the DOI.

Optional tasks:

  • add the description page for the custom semantics (currently #doi only)
  • in the datalink viewer, resolve the semantics as links to the description

@coveralls
Copy link

coveralls commented Dec 18, 2023

Pull Request Test Coverage Report for Build 7286872818

  • 4 of 21 (19.05%) changed or added relevant lines in 4 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.08%) to 63.873%

Changes Missing Coverage Covered Lines Changed/Added Lines %
daiquiri/datalink/views.py 2 5 40.0%
daiquiri/datalink/adapter.py 0 14 0.0%
Files with Coverage Reduction New Missed Lines %
daiquiri/datalink/views.py 1 55.56%
daiquiri/datalink/adapter.py 5 38.64%
Totals Coverage Status
Change from base Build 6612724739: -0.08%
Covered Lines: 4779
Relevant Lines: 7482

💛 - Coveralls

@kimakan kimakan marked this pull request as ready for review December 20, 2023 09:13
@kimakan kimakan merged commit 8376eb5 into master Dec 21, 2023
10 checks passed
@kimakan kimakan deleted the fix-datalink-doi-title branch December 27, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants