Dynamic datalink

[agy-why]

This is the first attempt to create dynamic datalink.

Why dynamic datalink?

making use of tables for datalink is useful since it allows more flexibility (for non-programmable entries) and it is easier to maintain.

Additionally the datalink entries are usually part of the release, and as such get a DOI.

However, in one cases making use of tables to provide datalink entries may not be confortable:

• in case of too many entries: like in Gaia, several datalink entries per source_id (same for applause...)

In these cases datalink entries generated on the fly based on the ID are necessary.

Implementation

I added a DynamicDatalinkAdapterMixin class that take care of the dynamic datalink entries. I also added a method called: get_datalink_rows and get_dyn_datalink_links to the BaseDatalinkAdapter, to provide a single point of gathering for the datalink entries (slighlty slower).

This improve greatly the maintenance and flexibility.

These changes should not break the former functionality.

How to

With this new implementation it is possible to add new datalink entries by overwriting the method:

get_dyn_datalink_links from the DatalinkAdapter. This method returns a list of dynamic datalink entries for the provided IDs. The user is free of implementing anything necessary. It just need to declare the new DatalinkAdapter in settings/base.py

Improvements

This pull request also solves some issues the previous implementation had:

1. There were various place in the code where the datalink data were gathered, making maintenance difficult
2. There were no flexibility in the way OAI and Datalink were connected (now there is an adapter).

[agy-why]

This is working with the dynamic-datalink branch of gaia-app

[agy-why]

tuple(link.values()) does not guaranty the order of the items in the resulting array.

[kimakan]

content_size should be changed to content_length (datalink standard)

[kimakan]

The current implementation breaks rebuild_oai_schema. The culprit is the re-implemented get_datalink_list which is used by rebuild_oai_schema. In general, this function must return all datalink entries with the semantic #doi. This must be addressed.

[coveralls]

Pull Request Test Coverage Report for Build 6311071061

• 9 of 40 (22.5%) changed or added relevant lines in 5 files are covered.
• 4 unchanged lines in 3 files lost coverage.
• Overall coverage decreased (-0.1%) to 63.98%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
daiquiri/datalink/viewsets.py	1	3	33.33%
daiquiri/oai/adapter.py	1	4	25.0%
daiquiri/query/models.py	0	5	0.0%
daiquiri/datalink/adapter.py	6	27	22.22%

Files with Coverage Reduction	New Missed Lines	%
daiquiri/datalink/viewsets.py	1	47.83%
daiquiri/query/models.py	1	71.29%
daiquiri/datalink/adapter.py	2	41.13%

Totals
Change from base Build 5715994248:	-0.1%
Covered Lines:	4723
Relevant Lines:	7382

---

💛 - Coveralls