Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed index.html typos #49

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Conversation

vcavanna
Copy link
Contributor

@vcavanna vcavanna commented Oct 2, 2023

Minifolio

Short Description

Wrote style edits for index.html. Most significant change is rewording the copy under "Hi, I'm a developer."
Take a look at the use of links too... Sketch now links to sketch.com, which is what I believe you were talking about.

Note: I'm asking to merge to main. I know this is against contribution guidelines, but I figured it was a small change and that this wouldn't be an issue. Let me know if I'm wrong.

Points Added Or Removed

Not sure.

Links To Issues

#5

Files Changed
index.html

@divyanshudhruv divyanshudhruv self-requested a review October 3, 2023 04:13
Copy link
Owner

@divyanshudhruv divyanshudhruv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job !

@divyanshudhruv divyanshudhruv merged commit f72e963 into divyanshudhruv:main Oct 3, 2023
@divyanshudhruv divyanshudhruv added hacktoberfest-accepted Accepted for hacktoberfest 🎉 Hacktoberfest 🔒 Closed The issue/pull request had been closed labels Oct 3, 2023
@divyanshudhruv divyanshudhruv mentioned this pull request Oct 3, 2023
divyanshudhruv added a commit that referenced this pull request Oct 3, 2023
This reverts the commit " #49 " due to error in styling of about section.
@divyanshudhruv divyanshudhruv removed hacktoberfest-accepted Accepted for hacktoberfest 🔒 Closed The issue/pull request had been closed labels Oct 3, 2023
@divyanshudhruv
Copy link
Owner

@vcavanna there is styling error when I merge this commit. Please check it and open a different pr. Sorry for inconvenience

@divyanshudhruv divyanshudhruv added hacktoberfest-accepted Accepted for hacktoberfest 🔒 Closed The issue/pull request had been closed labels Oct 3, 2023
@vcavanna vcavanna mentioned this pull request Oct 5, 2023
divyanshudhruv added a commit that referenced this pull request Oct 7, 2023
This commit reverts the changes made in " #49 " as they are no longer required.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔒 Closed The issue/pull request had been closed 🎉 Hacktoberfest hacktoberfest-accepted Accepted for hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants