Add Socials Sections

[newtoallofthis123]

This commit adds a social div to the website template.

It uses the same ionicons and also adds helpful comments.

[newtoallofthis123]

This closes #18

[divyanshudhruv]

Hey, nice work. But you can change the colors of the button to a flat color as it will look more nice.

[newtoallofthis123]

I will do that...but what do you mean by flat color? Can you please share an example?

[divyanshudhruv]

I mean color that seems soft to eyes

[newtoallofthis123]

Oh! Okay Done...will also help resolve a style.css conflict that happened :)

[divyanshudhruv]

Ok thank you, I hope you are able to resolve the style.css file conflict. Also please share the image after you changes the colors to a flat style by pinging me @divyanshudhruv

[newtoallofthis123]

Here are the colors @divyanshudhruv

[divyanshudhruv]

Nice, but you can increase the padding of button just like the Click me button and instead of going column wise, go row wise. Also set the width to fit content. Or just copy the button.css code, do necessary changes to color only and then write the code for button. I'll share you a pic soon about what we need for links

[newtoallofthis123]

I'll look into it

[divyanshudhruv]

I hope you didn't mind if I merge this request after 6 Oct as currently I do not have my device to look into the code.

[newtoallofthis123]

Oh that's alright! Take your time :)

[newtoallofthis123]

Something like this @divyanshudhruv

[divyanshudhruv]

Yeah, just add more padding and increase border radius by 3-4 px. You may also add a small line explaining that These are some of my social media handels Just like this-

[newtoallofthis123]

done

[divyanshudhruv]

Just like from LINE 51 to LINE 58 (it will add some apace after the title and the small line. It will Make the portolio look more minimal). Uncomment that do necessary changes and see the result.

Also use the fonts that are being used in the title and the small title

Use the prebuild button.css for styling the social media buttons

[divyanshudhruv]

Actually I am on my tab, and I can merge you pr only after 6oct. Sorry for late merge

[newtoallofthis123]

Don't worry about it

[newtoallofthis123]

😄 Look good?

[newtoallofthis123]

So I can commit?

[divyanshudhruv]

Yeah ! Just a little more margin bottom to the small title. Then it would be fine

[newtoallofthis123]

Okay

[divyanshudhruv]

Is the button animation working? If not, copy the button code from the about section and put it here. 🙂

[newtoallofthis123]

Animations would not work because the background is declared by the user.

[divyanshudhruv]

May share a picture of final commit. Other than this, nice work. ### Can I commit to your repo if I need some more changes ?

[newtoallofthis123]

cool :)

I did do the final commit

[divyanshudhruv]

Animations would not work because the background is declared by the user.

Ok, Can I fix that ? By pushing code to your main branch ?

[newtoallofthis123]

sure!

[divyanshudhruv]

Can you send the pic of the final code(the social link section)

[newtoallofthis123]

okay

[divyanshudhruv]

And the website ?

[divyanshudhruv]

Any updates ?

[newtoallofthis123]

It is actually really weird to add button animations with the background color. It is trade off at this point. I mean, the animation we added to other buttons was a darkening effect...but there is no way we can do that dynamically in css unless we use sass.

What do you say?

[divyanshudhruv]

Hey can you send a pic ? Of the website (social section)

[divyanshudhruv]

Please resolve the conflicts @newtoallofthis123

[divyanshudhruv]

@newtoallofthis123 can you publish the forked repo to gh pages? Then I can easily see the changes. Also send me the link after u successfully published

[newtoallofthis123]

Please resolve the conflicts @newtoallofthis123

Yeah I'll get to it

[newtoallofthis123]

@newtoallofthis123 can you publish the forked repo to gh pages? Then I can easily see the changes. Also send me the link after u successfully published

I can't really publish to gh pages since I don't own the repo....I'll see if i can get you a love preview

[divyanshudhruv]

Nono I mean publish your forked repo. That you can do I think

[newtoallofthis123]

Oh okay

[divyanshudhruv]

Ok

[Mukesh-ghildiyal]

if u don't mind shall i raise my new pr for this social sections,because i think its taking quite too much time

[divyanshudhruv]

@newtoallofthis123 yea, you can open a new PR