Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✏️ Style Edits to the Home Page #5

Closed
vcavanna opened this issue Sep 26, 2023 · 9 comments
Closed

✏️ Style Edits to the Home Page #5

vcavanna opened this issue Sep 26, 2023 · 9 comments
Assignees
Labels

Comments

@vcavanna
Copy link
Contributor

vcavanna commented Sep 26, 2023

🫤 Description


I'm offering a style correction, not a typo issue. There are no problems with the grammar from what I saw, but some style issues to make it sound better for the below lines.


📍 Location


File name: /index.html

Line number: 17, 33
URL: https://divyanshudhruv.github.io/Minifolio/


🧪 Correction


Line 17: "Learn more"
Line 33: I design websites. That's the long and short of it. I design UI and UX with Sketch, Design, and pretty decent HTML and CSS, while dabbling with Javascript and Java.


📦 Additional Information


Add any other relevant information here.


📌 Related Issue


Link to other issues related to this problem

@vcavanna
Copy link
Contributor Author

I also have another question. I don't really do frontend design. Are "sketch" and "design" tools that people use to design websites? If so, it might be useful to link or bold them so they stand out more. Design especially makes me just think of the verb "to design".

@divyanshudhruv divyanshudhruv added the ✏️ Typo Something isn't right label Sep 26, 2023
@divyanshudhruv
Copy link
Owner

divyanshudhruv commented Sep 26, 2023

Yes, true. Thank you for noticing the error @vcavanna . If you want, you can replace the error. But the correction in line:33 doesn't sound suitable. Try to make more better correction to the sentence . If you want may I assign the work to you ? You can contribute(open pull request after 1 oct for hacktoberfest) during hacktoberfest.

@vcavanna
Copy link
Contributor Author

Yes, assign it to me! I'll think about how to reword line:33. Right now I'm thinking it needs more active verbs (i.e. from this list).

@divyanshudhruv
Copy link
Owner

divyanshudhruv commented Sep 26, 2023

Ok , Assigning to you and you can open pull request during hacktoberfest... Good luck

@divyanshudhruv
Copy link
Owner

Hello, please visit here

@aahanatiwari
Copy link

hi, i'd like to participate in fixing this issue (hacktoberfest)

@divyanshudhruv
Copy link
Owner

@vcavanna ?

@SofiaHerrera27
Copy link

Hello, I would like to help contribute to your project in this issue.

@vcavanna
Copy link
Contributor Author

vcavanna commented Oct 2, 2023

Hi @divyanshudhruv it'll be done end of day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants