Add methods for adding/subtracting vectors #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjpatton
force-pushed
the
cjpatton/301
branch
from
fbb7f32 to
06f23a9
Compare
cjpatton
force-pushed
the
cjpatton/301
branch
from
06f23a9 to
4cda22e
Compare
cjpatton
force-pushed
the
cjpatton/301
branch
from
4cda22e to
f0653c1
Compare
Add a method `add_assign_vector` that replaces the following zip
pattern:
```
for (x, y) in a.iter_mut().zip(y) {
*x += *y;
}
```
The method also panics if `b` is shorter than `a`.
Replace the zip pattern with this method wherever we add up vectors.
This helps us ensure that we're not accidentally adding a vector that's
shorter than the other.
Likewise for subtracting vectors.
cjpatton
force-pushed
the
cjpatton/301
branch
from
f0653c1 to
1fddd55
Compare
jcjones
reviewed
Jan 22, 2025
divergentdave
approved these changes
Jan 23, 2025
jcjones
reviewed
Jan 23, 2025
| *x -= y; | ||
| count += 1; | ||
| } | ||
| assert_eq!(a.len(), count); |
There was a problem hiding this comment.
If we wanted to be real clever, we could add a debug assertion that a.len == b.len using #[cfg(debug_assertions)] to conditionally compile it.
There was a problem hiding this comment.
At this point, we only know b produces an iterator, so we'd have to do so in a more specialized method that takes two slices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #301: see #301 (comment).
Add a method
add_assign_vectorthat replaces the following zip pattern:The method also panics if
bis shorter thana.Replace the zip pattern with this method wherever we add up vectors. This helps us ensure that we're not accidentally adding a vector that's shorter than the other.
Likewise for subtracting vectors.