More Mastic clean up #1200
Merged
More Mastic clean up #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjpatton
force-pushed
the
cjpatton/947-15-cleanup
branch
from
1810f3a to
20bc920
Compare
cjpatton
changed the base branch from
cjpatton/947-14-truncated-weights
to
cjpatton/947-13-pseudorandom-eval
cjpatton
force-pushed
the
cjpatton/947-15-cleanup
branch
from
222d77b to
9645bba
Compare
cjpatton
force-pushed
the
cjpatton/947-13-pseudorandom-eval
branch
from
1c217a0 to
bbb9e04
Compare
cjpatton
force-pushed
the
cjpatton/947-15-cleanup
branch
from
9645bba to
3e92925
Compare
|
Rebased on #1198. |
divergentdave
approved these changes
Jan 16, 2025
cjpatton
force-pushed
the
cjpatton/947-13-pseudorandom-eval
branch
from
bbb9e04 to
4dbb408
Compare
This is redundant since `Vidpf` now needs to know the bit length.
Some of the implementation details of SZK are, for the moment, specific to Mastic. For example, the domain separation tag for each XOF invocation is prefixed by `b"mastic"`. It therefore makes sense to move this module to `mastic` until such time we need to refactor in order to use SZK in multiple places.
cjpatton
force-pushed
the
cjpatton/947-15-cleanup
branch
from
3e92925 to
386d288
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #1198.
Miscellaneous, somewhat opinionated clean up after completing Mastic.
seed_stream()take an arraybitsfield fromMasticstructszkmodule fromflptovdaf::mastic