mastic: Add test vectors, fix remaining bugs #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjpatton
commented
Jan 4, 2025
divergentdave
approved these changes
Jan 6, 2025
cjpatton
force-pushed
the
cjpatton/947-5
branch
from
bd26971 to
77af76e
Compare
Add test vectors for Mastic and fix the bugs they encounter: * Add domain separation to the payload check hash. * Truncate the weights prior to aggregation. * Adjust the order of the binder parts in the eval proof computation. * vidpf: Align public share encoding with the draft. * vidpf: Adjust index encoding in node proof. * vidpf: Align a few variable names with the spec. The test vectors were generated after making some changes to the spec based on our implementation experience here: jimouris/draft-mouris-cfrg-mastic#101
cjpatton
force-pushed
the
cjpatton/947-5
branch
from
77af76e to
454be10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #947. I plan to add more test vectors and clean up a few things.
Add test vectors for Mastic and fix the bugs they encounter:
The test vectors were generated after making some changes to the spec based on our implementation experience here:
jimouris/draft-mouris-cfrg-mastic#101