Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jsoniter-scala to 2.32.0 #1634

Closed
wants to merge 2 commits into from

Conversation

plokhotnyuk
Copy link
Contributor

Updates a year old version mostly for the performance reason, see

// TODO: can be improved with out.writeTimestampVal(x.epochSecond, x.nano) when https://github.com/plokhotnyuk/jsoniter-scala/releases/tag/v2.32.0 is used

@kubukoz
Copy link
Member

kubukoz commented Jan 2, 2025

can't decide whether this is CHANGELOG-worthy, so I'll leave it up to you

Copy link
Member

@kubukoz kubukoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmm looks like this isn't as straightforward as we thought

image

@plokhotnyuk plokhotnyuk closed this Jan 2, 2025
@plokhotnyuk plokhotnyuk deleted the patch-2 branch January 2, 2025 16:13
@plokhotnyuk
Copy link
Contributor Author

plokhotnyuk commented Jan 2, 2025

I will provide a new release of jsoniter-scala with a fix for negative timestamp and added support for writing timestamp as JSON keys

Also, it seems that Scala Native should be upgraded too.

@kubukoz
Copy link
Member

kubukoz commented Jan 2, 2025

Also, it seems that Scala Native should be upgraded too.

sigh...

we're going to be massively blocked by Cats Effect - for good reasons - typelevel/cats-effect#4076

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants