-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish snapshots on a schedule, make params bools #1093
Conversation
@@ -5,16 +5,21 @@ on: | |||
publishSnapshot: | |||
description: "Publish Snapshot" | |||
required: false | |||
default: "false" | |||
default: false | |||
type: boolean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes it a checkbox.
if: startsWith(github.ref, 'refs/tags/v') || (github.event_name == 'workflow_dispatch' && github.event.inputs.publishSnapshot == 'true') # || (github.ref == 'refs/heads/main') | ||
if: | ||
startsWith(github.ref, 'refs/tags/v') || | ||
github.event.inputs.publishSnapshot || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: I removed the event_name == workflow_dispatch
check, as I think it's redundant - at the moment, inputs can only be set by running a manual dispatch. In other jobs, the input defaults to false.
if: startsWith(github.ref, 'refs/tags/v') || (github.event_name == 'workflow_dispatch' && github.event.inputs.publishMicrosite == 'true') | ||
if: | ||
startsWith(github.ref, 'refs/tags/v') || | ||
github.event.inputs.publishMicrosite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above, removed the event_name check out of redundancy.
I didn't make the microsite get published on the schedule as schedules only run on the default branch, meaning we couldn't publish the site from series/0.17
that way.
@@ -99,7 +104,10 @@ jobs: | |||
release: | |||
name: Release | |||
needs: build | |||
if: startsWith(github.ref, 'refs/tags/v') || (github.event_name == 'workflow_dispatch' && github.event.inputs.publishSnapshot == 'true') # || (github.ref == 'refs/heads/main') | |||
if: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI I tested this out in a smaller repo: https://github.com/kubukoz/demos/actions/runs/5581376805/jobs/10199450921
No description provided.