Publish snapshots on a schedule, make params bools #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubukoz
commented
Jul 17, 2023
| @@ -5,16 +5,21 @@ on: | |||
| publishSnapshot: | |||
| description: "Publish Snapshot" | |||
| required: false | |||
| default: "false" | |||
| default: false | |||
| type: boolean | |||
There was a problem hiding this comment.
This makes it a checkbox.
| if: startsWith(github.ref, 'refs/tags/v') || (github.event_name == 'workflow_dispatch' && github.event.inputs.publishSnapshot == 'true') # || (github.ref == 'refs/heads/main') | ||
| if: | ||
| startsWith(github.ref, 'refs/tags/v') || | ||
| github.event.inputs.publishSnapshot || |
There was a problem hiding this comment.
note: I removed the event_name == workflow_dispatch check, as I think it's redundant - at the moment, inputs can only be set by running a manual dispatch. In other jobs, the input defaults to false.
| if: startsWith(github.ref, 'refs/tags/v') || (github.event_name == 'workflow_dispatch' && github.event.inputs.publishMicrosite == 'true') | ||
| if: | ||
| startsWith(github.ref, 'refs/tags/v') || | ||
| github.event.inputs.publishMicrosite |
There was a problem hiding this comment.
same as above, removed the event_name check out of redundancy.
I didn't make the microsite get published on the schedule as schedules only run on the default branch, meaning we couldn't publish the site from series/0.17 that way.
| @@ -99,7 +104,10 @@ jobs: | |||
| release: | |||
| name: Release | |||
| needs: build | |||
| if: startsWith(github.ref, 'refs/tags/v') || (github.event_name == 'workflow_dispatch' && github.event.inputs.publishSnapshot == 'true') # || (github.ref == 'refs/heads/main') | |||
| if: | |||
There was a problem hiding this comment.
FYI I tested this out in a smaller repo: https://github.com/kubukoz/demos/actions/runs/5581376805/jobs/10199450921
Baccata
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.