Merge pull request #1089 from disneystreaming/series-017-into-018-again

Merge series/0.17 into series/0.18 again

modules/aws-http4s/src/smithy4s/aws/AwsCredentialsFile.scala

@@ -85,7 +85,7 @@ object AwsCredentialsFile {
         case head :: next =>
           val parts = head.split("=")
           val key = parts(0).trim().toLowerCase
-          val value = parts(1).trim().toLowerCase()
+          val value = parts(1).trim()
           val updated = data + (key -> value)
           inProfile(next, currentProfile, updated)
       }

modules/aws-http4s/test/src/smithy4s/aws/AwsCredentialsFileTest.scala

@@ -46,6 +46,24 @@ object AwsCredentialsFileTest extends FunSuite {
     }
   }
 
+  test("be case sensitive") {
+    expectRight(
+      AwsCredentialsFile.processFileLines(
+        asLines(
+          """|[default]
+             |aws_secret_access_key = DeF_SeC
+             |aws_access_key_id     = dEf_KEy
+             |aws_session_token     = dEF_TokEn""".stripMargin
+        )
+      )
+    ) { res =>
+      expect.same(
+        Some(AwsCredentials.Default("dEf_KEy", "DeF_SeC", Some("dEF_TokEn"))),
+        res.default
+      )
+    }
+  }
+
   test("parse comments") {
     expectRight(
       AwsCredentialsFile.processFileLines(

modules/docs/markdown/06-guides/dynamic.md

@@ -30,7 +30,7 @@ Then, there's the **runtime** part. Let's say you're building an HTTP client - i
 ```scala
 SimpleRestJson(WeatherService)
   .client(??? : org.http4s.client.Client[IO])
-  .use
+  .make
 ```
 
 or more generically:
@@ -256,7 +256,7 @@ val service = dsi.getService(ShapeId("weather", "WeatherService")).get
 val client =
   SimpleRestJsonBuilder(service.service)
     .client(Client.fromHttpApp(routes))
-    .use
+    .make
     .toTry
     .get
 ```
@@ -271,7 +271,7 @@ run(
   service = service.service,
   operationName = "GetWeather",
   input = Document.obj("city" -> Document.fromString("London")),
-  alg = SimpleRestJsonBuilder(service.service).client(Client.fromHttpApp(routes)).use.toTry.get,
+  alg = client,
 ).unsafeRunSync().show
 ```
 
@@ -280,21 +280,25 @@ Enjoy the view! As an added bonus, because we happen to have this service at bui
 ```scala mdoc
 import weather._
 
-val clientInterpreter =
-  SimpleRestJsonBuilder(WeatherService).client(Client.fromHttpApp(routes)).use.toTry.get
+val clientStatic =
+  SimpleRestJsonBuilder(WeatherService)
+    .client(Client.fromHttpApp(routes))
+    .make
+    .toTry
+    .get
 
 run(
   service = WeatherService,
   operationName = "GetWeather",
   input = Document.obj("city" -> Document.fromString("London")),
-  alg = clientInterpreter,
+  alg = clientStatic,
 ).unsafeRunSync().show
 ```
 
 Again, this is equivalent to the following call in the static approach:
 
 ```scala mdoc
-clientInterpreter.getWeather(city = "London").unsafeRunSync()
+clientStatic.getWeather(city = "London").unsafeRunSync()
 ```
 
 [^1]: That is, assuming they're written correctly to make no assumptions about the usecase.

modules/http4s/src/smithy4s/http4s/ClientEndpointMiddleware.scala

@@ -17,17 +17,17 @@
 package smithy4s
 package http4s
 
-import cats.Monoid
 import org.http4s.client.Client
+import cats.kernel.Monoid
 
 // format: off
-trait ClientEndpointMiddleware[F[_]] { 
+trait ClientEndpointMiddleware[F[_]] {
   self =>
   def prepare[Alg[_[_, _, _, _, _]]](service: Service[Alg])(
       endpoint: Endpoint[service.Operation, _, _, _, _, _]
   ): Client[F] => Client[F]
 
-  def andThen(other: ClientEndpointMiddleware[F]): ClientEndpointMiddleware[F] = 
+  def andThen(other: ClientEndpointMiddleware[F]): ClientEndpointMiddleware[F] =
     new ClientEndpointMiddleware[F] {
       def prepare[Alg[_[_, _, _, _, _]]](service: Service[Alg])(
           endpoint: Endpoint[service.Operation, _, _, _, _, _]

modules/http4s/src/smithy4s/http4s/ServerEndpointMiddleware.scala

@@ -21,17 +21,17 @@ import cats.Monoid
 import cats.MonadThrow
 import cats.data.Kleisli
 import org.http4s.Response
-import cats.implicits._
 import org.http4s.HttpApp
+import cats.implicits._
 
 // format: off
 trait ServerEndpointMiddleware[F[_]] {
-  self  => 
+  self  =>
   def prepare[Alg[_[_, _, _, _, _]]](service: Service[Alg])(
       endpoint: Endpoint[service.Operation, _, _, _, _, _]
   ): HttpApp[F] => HttpApp[F]
 
-  def andThen(other: ServerEndpointMiddleware[F]): ServerEndpointMiddleware[F] = 
+  def andThen(other: ServerEndpointMiddleware[F]): ServerEndpointMiddleware[F] =
     new ServerEndpointMiddleware[F] {
       def prepare[Alg[_[_, _, _, _, _]]](service: Service[Alg])(
           endpoint: Endpoint[service.Operation, _, _, _, _, _]

modules/http4s/src/smithy4s/http4s/SimpleProtocolBuilder.scala

@@ -94,9 +94,9 @@ abstract class SimpleProtocolBuilder[P](
       new ClientBuilder[Alg, F](this.client, this.service, this.uri, mid)
 
     def resource: Resource[F, service.Impl[F]] =
-      use.leftWiden[Throwable].liftTo[Resource[F, *]]
+      make.leftWiden[Throwable].liftTo[Resource[F, *]]
 
-    def use: Either[UnsupportedProtocolError, service.Impl[F]] = {
+    def make: Either[UnsupportedProtocolError, service.Impl[F]] = {
       checkProtocol(service, protocolTag)
         // Making sure the router is evaluated lazily, so that all the compilation inside it
         // doesn't happen in case of a missing protocol
@@ -127,7 +127,7 @@ abstract class SimpleProtocolBuilder[P](
     /**
       * Applies the error transformation to the errors that are not in the smithy spec (has no effect on errors from spec).
       * Transformed errors raised in endpoint implementation will be observable from [[middleware]].
-      * Errors raised in the [[middleware]] will be transformed too. 
+      * Errors raised in the [[middleware]] will be transformed too.
       *
       * The following two are equivalent:
       * {{{
@@ -149,7 +149,7 @@ abstract class SimpleProtocolBuilder[P](
     /**
       * Applies the error transformation to the errors that are not in the smithy spec (has no effect on errors from spec).
       * Transformed errors raised in endpoint implementation will be observable from [[middleware]].
-      * Errors raised in the [[middleware]] will be transformed too. 
+      * Errors raised in the [[middleware]] will be transformed too.
       *
       * The following two are equivalent:
       * {{{

modules/http4s/test/src-jvm/smithy4s/http4s/Http4sDynamicPizzaClientSpec.scala

@@ -49,7 +49,7 @@ class DynamicHttpProxy(client: Client[IO]) {
       .flatMap { dsi =>
         SimpleRestJsonBuilder(dsi.service)
           .client[IO](client)
-          .use
+          .make
           .liftTo[IO]
           .map { dynamicClient =>
             JsonIOProtocol

modules/http4s/test/src/smithy4s/http4s/ProtocolBuilderSpec.scala

@@ -32,7 +32,7 @@ object ProtocolBuilderSpec extends FunSuite {
   ) {
     val result = SimpleRestJsonBuilder(WeatherGen)
       .client(fakeClient)
-      .use
+      .make
 
     assert(result.isLeft)
   }
@@ -42,7 +42,7 @@ object ProtocolBuilderSpec extends FunSuite {
   ) {
     val result = SimpleRestJsonBuilder(PizzaAdminServiceGen)
       .client(fakeClient)
-      .use
+      .make
 
     assert(result.isRight)
   }

modules/http4s/test/src/smithy4s/http4s/RecursiveInputSpec.scala

@@ -28,7 +28,7 @@ object RecursiveInputSpec extends FunSuite {
     val result =
       SimpleRestJsonBuilder(smithy4s.example.RecursiveInputService)
         .client(Client.fromHttpApp(HttpApp.notFound[IO]))
-        .use
+        .make
 
     expect(result.isRight)
   }

modules/http4s/test/src/smithy4s/http4s/ServerEndpointMiddlewareSpec.scala

@@ -201,7 +201,7 @@ object ServerEndpointMiddlewareSpec extends SimpleIOSuite {
         .middleware(
           new TestClientMiddleware(shouldFail = shouldFailInMiddleware)
         )
-        .use
+        .make
         .toOption
         .get
     }