[DDST-215] Drush 12 compatibility #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://www.drush.org/12.x/dependency-injection/#create-method, the type should be `Psr\Container\ContainerInterface`, not `Symfony\Component\DependencyInjection\ContainerInterface`, which I almost didn't catch because both seem to work, but I'm making this change since it's specifically called out in the documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error encountered prior to these fixes:
Attempting to run the
drush dgi_actions:generateordrush dgi_actions:print_idscommands got this error:Turns out the namespacing and addition of the create() method for dependency injection wasn't the thing preventing the commands in the dgi_actions namespace from being found, since those changes are actually only going to be strictly necessary in Drush 13...still worth including that future-proofing, but the real bug was the
logger.dgi_actionslisted in drush.services.yml which is an issue I only found by adding the-vvvtag when trying to run either of those dgi_actions drush commands:Service logger.dgi_actions does not have a class element; skipping modules/contrib/dgi_actions/drush.services.ymlSo, the only necessary change in the end appears to be that logger change, but the other cleanup is still worth keeping since it was mostly done before realizing it would only be strictly required for Drush 13.