FIX: N1 in post action extension #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-brennan
commented
May 20, 2024
plugin.rb
Outdated
| @@ -104,6 +104,20 @@ class Engine < ::Rails::Engine | |||
|
|
|||
| reaction_users_counting_as_like.flatten! | |||
|
|
|||
| # Used to remove historical like data in the filter below. | |||
| previous_main_reaction_like_ids = | |||
There was a problem hiding this comment.
We can potentially add a spec using track_sql_queries for this, but since this is one of many add_to_serializer modifications to the PostSerializer, it's not really possible to do a clean before/after comparison without some more extensive refactoring, which I do not think is worth it at this time. Confirmed that the N1 is now gone locally.
Followup 0b4b186 The previous commit caused an N1 because I was calling post_action.reaction_user in a loop, which was making a query for every Like PostAction attached to a Post.
martin-brennan
force-pushed
the
issue/fix-n1-post-action-extension
branch
from
1e0844f to
f6a847a
Compare
ZogStriP
approved these changes
May 20, 2024
tgxworld
reviewed
May 20, 2024
jjaffeux
approved these changes
May 20, 2024
tgxworld
reviewed
May 20, 2024
martin-brennan
force-pushed
the
issue/fix-n1-post-action-extension
branch
2 times, most recently
from
ece718c to
46284bf
Compare
tgxworld
reviewed
May 21, 2024
tgxworld
approved these changes
May 21, 2024
martin-brennan
force-pushed
the
issue/fix-n1-post-action-extension
branch
from
46284bf to
88b849c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup 0b4b186
The previous commit caused an N1 because I was calling
post_action.reaction_user in a loop, which was making
a query for every Like PostAction attached to a Post.