DEV: Update linting (#32)

discourse · Mar 27, 2024 · 23863de · 23863de
1 parent 3060d62
commit 23863de
Show file tree

Hide file tree

Showing 10 changed files with 1,345 additions and 696 deletions.
diff --git a/.eslintrc b/.eslintrc
diff --git a/.eslintrc.cjs b/.eslintrc.cjs
@@ -0,0 +1 @@
+module.exports = require("@discourse/lint-configs/eslint-theme");
diff --git a/.prettierrc b/.prettierrc
diff --git a/.prettierrc.cjs b/.prettierrc.cjs
@@ -0,0 +1 @@
+module.exports = require("@discourse/lint-configs/prettier");
diff --git a/.template-lintrc.cjs b/.template-lintrc.cjs
@@ -0,0 +1 @@
+module.exports = require("@discourse/lint-configs/template-lint");
diff --git a/.template-lintrc.js b/.template-lintrc.js
diff --git a/javascripts/discourse/components/featured-homepage-topics.hbs b/javascripts/discourse/components/featured-homepage-topics.hbs
@@ -8,7 +8,7 @@
       <div class="custom-homepage">
         {{#if (theme-setting "make_collapsible")}}
           <DButton
-            @class={{concat-class
+            class={{concat-class
               "featured-topic-toggle"
               (if toggleTopics "is-open")
             }}

diff --git a/javascripts/discourse/components/featured-homepage-topics.js b/javascripts/discourse/components/featured-homepage-topics.js
@@ -1,7 +1,7 @@
 import Component from "@glimmer/component";
-import { inject as service } from "@ember/service";
-import { action } from "@ember/object";
 import { tracked } from "@glimmer/tracking";
+import { action } from "@ember/object";
+import { service } from "@ember/service";
 import { defaultHomepage } from "discourse/lib/utilities";
 import I18n from "I18n";
 
@@ -15,7 +15,8 @@ export default class FeaturedHomepageTopics extends Component {
   @service keyValueStore;
 
   @tracked featuredTagTopics = null;
-  @tracked toggleTopics =
+  @tracked
+  toggleTopics =
     this.keyValueStore.getItem("toggleTopicsState") === "true" || false;
 
   constructor() {
@@ -30,6 +31,7 @@ export default class FeaturedHomepageTopics extends Component {
   }
 
   willDestroy() {
+    super.willDestroy(...arguments);
     this.router.off("routeDidChange", this.checkShowHere);
   }
 

diff --git a/package.json b/package.json
@@ -1,10 +1,9 @@
 {
-  "name": "discourse-homepage-feature-component",
-  "version": "1.0.0",
-  "repository": "https://github.com/discourse/discourse-homepage-feature-component",
-  "author": "Discourse",
-  "license": "GPL-2.0-or-later",
+  "private": true,
   "devDependencies": {
-    "eslint-config-discourse": "^3.1.0"
+    "@discourse/lint-configs": "^1.3.7",
+    "ember-template-lint": "^5.13.0",
+    "eslint": "^8.56.0",
+    "prettier": "^2.8.8"
   }
 }
diff --git a/yarn.lock b/yarn.lock
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		module.exports = require("@discourse/lint-configs/eslint-theme");