DEV: Handle empty strings for small_links migration

Follow up to 105b001
discourse · May 6, 2024 · 7c930d3 · 7c930d3
1 parent 105b001
commit 7c930d3
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/migrations/settings/0003-migrate-small-links-setting.js b/migrations/settings/0003-migrate-small-links-setting.js
@@ -31,6 +31,8 @@ export default function migrate(settings, helpers) {
     });
 
     settings.set("small_links", newSmallLinks);
+  } else if (oldSmallLinks?.trim() === "") {
+    settings.set("small_links", []);
   }
 
   return settings;

diff --git a/spec/migrations/0003_migrate_small_links_setting_spec.rb b/spec/migrations/0003_migrate_small_links_setting_spec.rb
@@ -3,6 +3,19 @@
 RSpec.describe "0003-migrate-small-links-setting migration" do
   let!(:theme) { upload_theme_component }
 
+  it "should handle an empty string for old setting" do
+    theme.theme_settings.create!(
+      name: "small_links",
+      theme:,
+      data_type: ThemeSetting.types[:string],
+      value: "    ",
+    )
+
+    run_theme_migration(theme, "0003-migrate-small-links-setting")
+
+    expect(theme.settings[:small_links].value).to eq([])
+  end
+
   it "should set target property to `_blank` if previous target component is not valid or empty" do
     theme.theme_settings.create!(
       name: "small_links",