Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Create a new scope when building interaction service modules if AutoServiceScopes = true #3028

Merged
merged 2 commits into from
Nov 16, 2024
Merged

[Fix] Create a new scope when building interaction service modules if AutoServiceScopes = true #3028

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc01c8c
Update ModuleBuilder.cs
Misha-133 Nov 16, 2024
d3dd9fc
oh right the `using`
Misha-133 Nov 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Discord.Net.Interactions/Builders/ModuleBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
using Microsoft.Extensions.DependencyInjection;
using System;
using System.Collections.Generic;
using System.Reflection;
Expand Down Expand Up @@ -461,6 +462,10 @@ internal ModuleInfo Build(InteractionService interactionService, IServiceProvide
{
if (TypeInfo is not null && ModuleClassBuilder.IsValidModuleDefinition(TypeInfo))
{
using var scope = services?.CreateScope();
if (interactionService._autoServiceScopes)
services = scope?.ServiceProvider ?? EmptyServiceProvider.Instance;

var instance = ReflectionUtils<IInteractionModuleBase>.CreateObject(TypeInfo, interactionService, services);

try
Expand Down