Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkov #14

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions .github/workflows/checkov.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
on: [push]
jobs:
checkov-job:
runs-on: ubuntu-latest
name: checkov-action
steps:
- name: Checkout repo
uses: actions/checkout@master

- name: Run Checkov action
id: checkov
uses: bridgecrewio/checkov-action@master
with:
directory: charts/directus
quiet: false # optional: display only failed checks
soft_fail: true # optional: do not return an error code if there are failed checks
framework: helm # optional: run only on a specific infrastructure {cloudformation,terraform,kubernetes,all}
output_format: sarif # optional: the output format, one of: cli, json, junitxml, github_failed_only, or sarif. Default: sarif

8 changes: 4 additions & 4 deletions charts/directus/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ appVersion: "9.5.1"

dependencies:
- name: mariadb
version: "9.3.13"
repository: "https://charts.bitnami.com/bitnami"
version: "12.2.4"
repository: "oci://registry-1.docker.io/bitnamicharts"
condition: mariadb.enabled
- name: redis
version: "14.3.2"
repository: "https://charts.bitnami.com/bitnami"
version: "17.11.3"
repository: "oci://registry-1.docker.io/bitnamicharts"
condition: redis.enabled
25 changes: 12 additions & 13 deletions charts/directus/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
replicaCount: 1

image:
repository: directus/directus
repository: directus/directus
pullPolicy: IfNotPresent
# Overrides the image tag whose default is the chart appVersion.
tag: "9.5.1"
Expand Down Expand Up @@ -50,11 +50,8 @@ ingress:
paths:
- path: /
backend:
service:
name: chart-example.local
port:
number: 80
pathType: ImplementationSpecific
serviceName: chart-example.local
servicePort: 80
tls: []
# - secretName: chart-example-tls
# hosts:
Expand Down Expand Up @@ -260,7 +257,8 @@ mariadb:
## updateStrategy for Mariadb Primary statefulset
## ref: https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#update-strategies
##
updateStrategy: RollingUpdate
updateStrategy:
type: RollingUpdate

## Partition update strategy for Mariadb Primary statefulset
## https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#partitions
Expand Down Expand Up @@ -556,7 +554,8 @@ mariadb:
## updateStrategy for Mariadb Secondary statefulset
## ref: https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#update-strategies
##
updateStrategy: RollingUpdate
updateStrategy:
type: RollingUpdate

## Partition update strategy for Mariadb Secondary statefulset
## https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#partitions
Expand Down Expand Up @@ -963,7 +962,7 @@ mariadb:

## Array with extra yaml to deploy with the chart. Evaluated as a template
##
extraDeploy: []
extraDeploy: []

redis:
enabled: true
Expand Down Expand Up @@ -1292,7 +1291,7 @@ redis:
## - name: portname
## containerPort: 1234
##
sidecars: {}
sidecars: []
## @param master.initContainers Add additional init containers to the Redis(TM) master pod(s)
## ref: https://kubernetes.io/docs/concepts/workloads/pods/init-containers/
## e.g:
Expand All @@ -1302,7 +1301,7 @@ redis:
## imagePullPolicy: Always
## command: ['sh', '-c', 'echo "hello world"']
##
initContainers: {}
initContainers: []
## Persistence parameters
## ref: http://kubernetes.io/docs/user-guide/persistent-volumes/
##
Expand Down Expand Up @@ -1592,7 +1591,7 @@ redis:
## - name: portname
## containerPort: 1234
##
sidecars: {}
sidecars: []
## @param replica.initContainers Add additional init containers to the Redis(TM) replicas pod(s)
## ref: https://kubernetes.io/docs/concepts/workloads/pods/init-containers/
## e.g:
Expand All @@ -1602,7 +1601,7 @@ redis:
## imagePullPolicy: Always
## command: ['sh', '-c', 'echo "hello world"']
##
initContainers: {}
initContainers: []
## Persistence Parameters
## ref: http://kubernetes.io/docs/user-guide/persistent-volumes/
##
Expand Down