Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper update of logging incl. test files #767

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Conversation

astjoephysics
Copy link
Collaborator

Fixes #682 .

Describe your changes.
Made logging consistent with Python logger by taking logging out of sorchaArguments. Updated tests accordingly.

Review Checklist for Source Code Changes

  • Does pip install still work?
  • Have you written a unit test for any new functions?
  • Do all the units tests run successfully?
  • Does Sorcha run successfully on a test set of input files/databases?
  • Have you used black on the files you have updated to confirm python programming style guide enforcement?

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (0d681a8) 74.68% compared to head (fb03505) 74.80%.

Files Patch % Lines
src/sorcha/sorcha.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #767      +/-   ##
==========================================
+ Coverage   74.68%   74.80%   +0.12%     
==========================================
  Files          66       66              
  Lines        3030     3021       -9     
==========================================
- Hits         2263     2260       -3     
+ Misses        767      761       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mschwamb mschwamb self-requested a review January 8, 2024 16:49
Changing this back since it was changed for no reason.
Copy link
Collaborator

@mschwamb mschwamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to be. Made a small change to put the verbosity of the log file back to what was in the original unit test

@astjoephysics astjoephysics merged commit a050399 into main Jan 8, 2024
10 checks passed
@astjoephysics astjoephysics deleted the loggingupdate branch January 8, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

standardized initialization of pplogger stored in args
2 participants