Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fading function on behave like linkingfilter #1103

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

Little-Ryugu
Copy link
Collaborator

Fixes #1101

The user will no longer need to set fading_function_on to True or False. Instead, when the fading function section is not included then fading_function_on will be false.

Review Checklist for Source Code Changes

  • Does pip install still work?
  • Have you written a unit test for any new functions?
  • Do all the units tests run successfully?
  • Does Sorcha run successfully on a test set of input files/databases?
  • Have you used black on the files you have updated to confirm python programming style guide enforcement?

Little-Ryugu and others added 4 commits January 17, 2025 12:08
Flag fading_function_on will now turn off or on depending if fading_function_width and fading_function_width have been set in the config file.
@Little-Ryugu Little-Ryugu marked this pull request as ready for review January 17, 2025 14:39
@Little-Ryugu Little-Ryugu merged commit 0bfc9cc into main Jan 17, 2025
7 checks passed
@Little-Ryugu Little-Ryugu deleted the fading_function_on-behave-like-linkingfilter branch January 17, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch fading function config section to behave like linking filter config variables
2 participants