Sorcha cite command line function #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a sorcha cite command line funtion with two optional arguments. An argument to print the citation to the terminal and an argument to decide the file path
Changed the function cite_sorcha() print statements to f.write and set the default to be sys.stdout. Made some formatting changes to the citation text to make it more readable when outputted in the text file. Updated the docs to include this method of getting the citation information
mschwamb
reviewed
Jan 14, 2025
|
|
||
| if args.p: # prints citation to terminal | ||
| cite_sorcha() | ||
|
|
There was a problem hiding this comment.
it looks if I have with -p it will execute both printing to a file and to the terminal
There was a problem hiding this comment.
shouldn't there be an else and then the rest?
mschwamb
requested changes
Jan 14, 2025
…dirac-institute/sorcha into making-a-sorcha-cite-in-the-CLI
fixing description typo
mschwamb
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1091.
Created a Sorcha cite command line function with two optional arguments. An argument to print the citation to the terminal and an argument to decide the file path
Review Checklist for Source Code Changes