Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update js to 0.7.1 (was 0.6.7) #181

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

techouse
Copy link

@techouse techouse commented Apr 24, 2024

This PR updates the js dependency to v0.7.1 until the project gets ported to dart:js_interop.

  • all package tests passed locally

@sunderee
Copy link

It would be great to see this PR land ASAP.

@LeoRc01
Copy link

LeoRc01 commented May 31, 2024

Is there a way to refer to this commit in the pubspec.yaml ?

@techouse
Copy link
Author

techouse commented May 31, 2024

Is there a way to refer to this commit in the pubspec.yaml ?

Of course,

dependency_overrides:
  cryptography:
    git:
      url: https://github.com/techouse/cryptography
      ref: chore/update-js
      path: cryptography

alternatively, you could just override js directly, i.e.

dependency_overrides:
  js: ^0.7.1

@levelupatlas-mat
Copy link

Any reason not to merge this?

@sunderee sunderee mentioned this pull request Oct 11, 2024
@sunderee
Copy link

At this point, I think instead of bumping the js version, perhaps migration to js_interop would be a better idea. This would allow for WASM compilation.

@ziadsarour
Copy link

This package seems abandoned.
This PR was created 6 months ago (still not merged and it's just a dependency update) and the last merged PR was in September 2023..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants