Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow playing custom streams #94

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

jacksonh
Copy link
Contributor

Opening this up just to see if you are OK with the approach, I still have some refactoring to do and will add an example/test.

This lets users implement custom streams that can be played with AudioStreaming. For example, I have a websocket interface that I fetch data from. I can wrap that stream into a CoreAudioStreamSource and add that to the player. Another example would be decrypting data.

This lets users implement custom streams that can be played. For
example, I have a websocket interface that I fetch data from. I
can wrap that stream into a CoreAudioStreamSource and add that to
the player.
@dimitris-c
Copy link
Owner

Nice one, thanks. Could you write a simple custom CoreAudioStreamSource on the example project? Just to verify the behaviour. And I guess the same API can be used for the queue method.

@jacksonh
Copy link
Contributor Author

Nice one, thanks. Could you write a simple custom CoreAudioStreamSource on the example project? Just to verify the behaviour. And I guess the same API can be used for the queue method.

Thanks! Good call on the queue method. I'm trying to put together a simplified example and tests now.

@dimitris-c dimitris-c self-requested a review September 13, 2024 08:55
@jacksonh
Copy link
Contributor Author

FYI, just fleshing out my use of this more in our app to see if there's anything I'd want to change. Also still plan on completing the queue methods.

@jacksonh jacksonh marked this pull request as ready for review September 17, 2024 07:02
@jacksonh
Copy link
Contributor Author

Took a bit to get to that, but using in my app now with this branch and all seems to be working well.

@jacksonh
Copy link
Contributor Author

let me know if you want me to add anything else here. Trying to figure out a way to test better.

@dimitris-c dimitris-c merged commit 624e575 into dimitris-c:main Sep 19, 2024
1 check passed
@dimitris-c
Copy link
Owner

Released on 1.2.6

@jacksonh jacksonh deleted the jacksonh/external-stream-sources branch September 23, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants