Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create constructor for ConvexPolyline that does not remove any vertices #278

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Ughuuu
Copy link
Contributor

@Ughuuu Ughuuu commented Oct 6, 2024

  • Fixes Give option to not remove vertices when constructing ConvexPolyline and other such shapes #277
    In Godot Rapier, Godot sends vertices that it uses to draw the polygon. If Parry removes some vertices, then the physics will not work correct. We need the extra vertices even if collinear, and ideally have the collinearity check done in Godot at some point or sent as a warning to console. For now a function that accepts points and doesn't remove any is needed for this use case.

@Ughuuu Ughuuu force-pushed the create-constructor-that-does-not-remove-points branch from ffc7300 to 4eb05f7 Compare October 6, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Give option to not remove vertices when constructing ConvexPolyline and other such shapes
1 participant