Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convex hull example #256

Merged
merged 23 commits into from
Sep 20, 2024
Merged

Convex hull example #256

merged 23 commits into from
Sep 20, 2024

Conversation

Vrixyz
Copy link
Contributor

@Vrixyz Vrixyz commented Sep 3, 2024

This builds on #250 to take advantage of common_macroquad code.

Screencast.from.09-03-2024.03.21.04.PM.webm
Screencast.from.09-03-2024.04.06.20.PM.webm

@Vrixyz Vrixyz marked this pull request as draft September 3, 2024 13:24
Copy link
Member

@sebcrozet sebcrozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this (and all the similar PRs) needs to be rebased on main to lighten the size of te diff.

@Vrixyz Vrixyz marked this pull request as ready for review September 13, 2024 09:27
@Vrixyz
Copy link
Contributor Author

Vrixyz commented Sep 13, 2024

I merged master in ; in order to be able to reuse the same conflict resolution on similar pr

Copy link
Member

@sebcrozet sebcrozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/transformation/to_trimesh/cuboid_to_trimesh.rs Outdated Show resolved Hide resolved
@Vrixyz Vrixyz merged commit c385c9b into dimforge:master Sep 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants