Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If we have less than 3 points return empty convex hull #165

Merged
merged 5 commits into from
Jul 20, 2024

Conversation

Aceeri
Copy link
Contributor

@Aceeri Aceeri commented Sep 17, 2023

Ran into this issue where providing a single point would panic rather than just return None when creating a convex hull collider.

@sebcrozet sebcrozet merged commit 7c8faee into dimforge:master Jul 20, 2024
5 checks passed
@sebcrozet
Copy link
Member

Thank you! I modified the code so it returns an error instead of an empty convex hull if less than 3 points are provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants