-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added flag to make wrapping username with domain optional (to support basic auth). #1290
Conversation
@OrangeAndGreen Where can I see the corresponding Android code for this PR ? Basically want to see what changes in Android code necessitate the need of basic auth class as it looks exactly same as |
Of course, that makes sense! The relevant change is in the |
That makes sense, one other way to do that would be to just add a |
Ah, I think I like your |
… domain (instead of additional BasicAuth class).
Ok, change made and ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Dave this looks good. Couple things around core PRs -
-
It's a good practice to PR the corresponding Android/Formplayer repo change along with the Core changes and cross-request them to each other. That way we have a history of why a change was made in core.
-
We need to duplicate all the core PRs across
formplayer
andmaster
. The process for that is outlined here.
cross-request: dimagi/commcare-android#2660 |
Duplicate this PR |
Technical Summary
Added a dedicated BasicAuth class that the Android code can use to perform basic HTTP auth without any additional wrapping. The Android code does a type check on the AuthInfo to determine what credentials to send up, and other sub-classes involve additional steps that don't work for basic auth.
Safety Assurance
Safety story
Simply adding a class here for commcare-android to use.
Automated test coverage
No new tests.
Special deploy instructions
Rollback instructions
Review
Duplicate PR
Automatically duplicate this PR as defined in contributing.md.