Fixes Crash on App Resume after Session Expiration #2799
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. handler somehow when resuming the view
shubham1g5
changed the title
|
@damagatchi retest this please |
shubham1g5
requested review from
avazirna and
ctsims
and removed request for
ctsims and
avazirna
|
@shubham1g5 this looks right to me. I wonder if we should consider adding this to |
Yeah that sounds good to me. |
|
Closing in favour of #2814 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Handles SessionExpiration in the home button view setup, this escapes the default session expiration and causes the app to crash when resuming after a session expiration event. Other buttons already have this safety implemented and sync was the only one remaining.
Adds some helpful logs around session expiration
Safety Assurance