Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apk dependencies additions #2796

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Apk dependencies additions #2796

merged 1 commit into from
Jul 31, 2024

Conversation

shubham1g5
Copy link
Contributor

Summary

Adds common Android apps packages CC may depend on for App depndency.

Safety Assurance

  • If the PR is high risk, "High Risk" label is set
  • I have confidence that this PR will not introduce a regression for the reasons below
  • Do we need to enhance manual QA test coverage ? If yes, "QA Note" label is set correctly

Automated test coverage

NA

Safety story

No business logic change. A build pass should confirm the safety here.

@shubham1g5 shubham1g5 requested a review from avazirna July 31, 2024 05:32
@shubham1g5 shubham1g5 changed the base branch from master to commcare_2.54 July 31, 2024 05:32
@shubham1g5 shubham1g5 added the skip-integration-tests Skip android tests. label Jul 31, 2024
@shubham1g5
Copy link
Contributor Author

@damagatchi retest this please

@shubham1g5 shubham1g5 merged commit 10b81c8 into commcare_2.54 Jul 31, 2024
5 of 9 checks passed
@shubham1g5 shubham1g5 deleted the app_dependencies_additions branch July 31, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avazirna avazirna avazirna approved these changes

Assignees
No one assigned
Labels
skip-integration-tests Skip android tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shubham1g5 @avazirna