Changed compile SDK version to 33. #2693
Conversation
Fixed a new error in DrawingBoundaryActivity.kt handling a nullable Location.
| if (location != null && location.accuracy <= locationMinAccuracy) { | ||
| val addLocation = previousLocation == null || |
There was a problem hiding this comment.
curious what was the compile error with earlier code ?
There was a problem hiding this comment.
The previousLocation variable is a nullable Location but the distanceTo function won't accept null and generated a compile error. We actually null check previousLocation before entering the code block that calls distanceTo, but it's a class member so the compiler assumes it could be changed from somewhere else in the code. The fix was to simply retrieve the previousLocation into a local prevLocation variable, then null check and use that.
app/build.gradle
Outdated
| @@ -249,7 +249,7 @@ android { | |||
|
|
|||
| defaultConfig { | |||
| minSdkVersion 21 | |||
| targetSdkVersion 31 | |||
| targetSdkVersion 33 | |||
There was a problem hiding this comment.
@OrangeAndGreen We can't change the targetSdkVersion without actually making the supporting Android 33 changes that Ahmad is working on. I think we should only be able to change the compileSdkVersion for incorporating the navigation UI component in code.
OrangeAndGreen
changed the title
…nto dv/compile_sdk_33
|
@damagatchi Retest this please |
1 similar comment
|
@damagatchi Retest this please |
|
Actually Closing this in favour of #2683 as we need to get those changes in anyway. |
Fixed a new error in DrawingBoundaryActivity.kt handling a nullable Location.
Summary
Changed from API 31 to 33 to support future work.
Safety Assurance
Safety story
A new compile error appeared in DrawingBoundaryActivity.kt involving safe usage of a nullable Location, so the code was changed slightly to handle the error.