Reverse Index Transform implementation #2674
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements the necessary index table interface methods for
dimagi/commcare-core#1283
and a test for the optimization trigger.
Note - Needs to be rolled in with the formplayer merge, will fail until then.
Feature Flag
N/A
Product Description
N/A
Safety Assurance
Automated test coverage
Unit tests cover the new test structure.
Safety story
Other optimization tests currently have poor coverage of their actual effect on test query plans. The tests cover regressions in query output (IE: whether an engine change results in the expressions providing a different response) but do not really currently cover comprehensively that expected optimizations process. I think we should implement those checks on more of the regressions before incorporating the change.