Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConnectID Initial Implementation #2660

Merged
merged 79 commits into from
Aug 24, 2023
Merged

Commits on Mar 2, 2023

  1. Configuration menu
    Copy the full SHA
    6153242 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. Got rid of locked state for Connect ID (only logged out or logged in).

    Getting ready for network calls.
    OrangeAndGreen committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    466026c View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2023

  1. Renamed some files for consistency.

    Initial registration workflow working.
    Implemented basic photos page and SMS verification.
    OrangeAndGreen committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    06f9936 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2023

  1. Changes to initial ConnectID create/recovery workflow.

    Basic password manager implementation after ConnectID login.
    OrangeAndGreen committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    6d7b527 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2023

  1. Configuration menu
    Copy the full SHA
    87c6d0f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1bfa868 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d16af33 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2023

  1. Changed min SDK to 23.

    Implemented local encrypted DB for data related to Connect.
    OrangeAndGreen committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    a60a863 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2023

  1. Added activity for getting Connect recovery vs. new account decision.

    Some cleanup after achieving POC functionality.
    Using secure storage for password manager functionality.
    OrangeAndGreen committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    e2cb6cb View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2023

  1. Configuration menu
    Copy the full SHA
    f07b4ed View commit details
    Browse the repository at this point in the history

Commits on May 2, 2023

  1. Remembering registration phase to resume after app interruption.

    Several UI improvements, rewording.
    OrangeAndGreen committed May 2, 2023
    Configuration menu
    Copy the full SHA
    5bd6747 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. Icons instead of highlighted text on two pages.

    A couple small bug fixes.
    Preparing for OIDC calls.
    OrangeAndGreen committed May 3, 2023
    Configuration menu
    Copy the full SHA
    0cf3b66 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. ConnectID V1 development, including several new activities.

    Moved ConnectID activities into a sub-namespace called connect.
    OrangeAndGreen committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    52b1bb7 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. Added ConnectID unlock functionality as a developer option.

    Showing recovery phone number in UI when sending alt OTP.
    OrangeAndGreen committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    e5590c6 View commit details
    Browse the repository at this point in the history
  2. Improved ConnectID DB encryption using Android KeyStore.

    Now encrypting DB passphrase using a Cipher, and storing the encrypted passphrase in the global DB.
    Added table to global DB for storing ConnectKeyRecords (changed DB version to 6).
    Min SDK Version moved back to 16 now that we aren't using newer helper classes (EncryptedFile, MasterKeys).
    OrangeAndGreen committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    db457b4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    23881d8 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Fixed bug where password sometimes wouldn't auto-fill when it should.

    Not allowing password option when prompting for biometric unlock during registration.
    Fixed bug where ConnectID button on login page would appear after logging out of an app even if ConnectID user was not configured.
    Disabled auto-login to app after unlocking ConnectID.
    OrangeAndGreen committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    303cac5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    74a21d6 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. Configuration menu
    Copy the full SHA
    ab4e140 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    64ca2d2 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2023

  1. Added phone number checking to recovery decision page before allowing…

    … user to proceed to OTP page.
    OrangeAndGreen committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    4db49b5 View commit details
    Browse the repository at this point in the history
  2. Moved a bunch of ConnectID-related strings from android_translatable_…

    …strings.txt to strings.xml.
    
    Re-enabled strict mode.
    Small improvements to EncryptionUtils for versions before Android M.
    Some other small changes based on PR review.
    OrangeAndGreen committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    a0ce2ea View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. Added some (temporary) error reporting to API call that checks if pho…

    …ne number is available, for debugging.
    OrangeAndGreen committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    2c35dfb View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. Styling improvements.

    Added code for encrypting DB in Android version before API 23.
    Fixed going to alt. phone verification after password fails three times.
    Added better consent wording, links, and checkbox.
    OrangeAndGreen committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    78bcb6a View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. Solved DB passphrase encryption for API 21 and lower.

    Some bug fixes for QA tickets.
    Better error messaging on registration and phone verification pages.
    OrangeAndGreen committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    88e094a View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2023

  1. Showing ConnectID page titles in blue bar at top of screen.

    Storing alt number in Connect DB.
    Not allowing user to change primary number to match alt number.
    Fixed bugs involving forgetting ConnectID user and saved app credentials.
    OrangeAndGreen committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    1cca84f View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Added AppSelectActivity initial implementation (not using yet).

    Changed code to update primary phone ad main reg. info when user returns to those screens after initial creation.
    Improvements to recovering workflow after crash or backup to start.
    OrangeAndGreen committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    3fc9f5a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    46aa87f View commit details
    Browse the repository at this point in the history
  3. don't set parent activity null on forget user as it causes crash when…

    … user click on sign up again
    shubham1g5 committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    8069967 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a1c37f4 View commit details
    Browse the repository at this point in the history
  5. Showing ConnectID sign-in menu option when user resumes registration …

    …workflow after interruption.
    OrangeAndGreen committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    371d2d2 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2023

  1. Configuration menu
    Copy the full SHA
    6d7d1b8 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. 2-minute countdown between OTP requests.

    Storing updated info during registration.
    Skipping to password-only workflow when fingerprint and PIN are unavailable.
    OrangeAndGreen committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    57a8178 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Configuration menu
    Copy the full SHA
    7a436c2 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. BROKEN: Attempting to use getRecordsForValues to query app_data records.

    Added Registering state to ConnectIDManager for when user is mid-registration.
    Fixed some issues raised in PR.
    OrangeAndGreen committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    16521f2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e0c18e8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    44ec36a View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. Configuration menu
    Copy the full SHA
    a3c66aa View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Changed UI and some workflow for biometrics configuration.

    Moved alternate phone input to its own page at end of reg. workflow.
    OrangeAndGreen committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    457ef9e View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. Logs connect signins

    shubham1g5 committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    ced400a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    993b8e9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    68747e0 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Configuration menu
    Copy the full SHA
    7774ea7 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2687 from dimagi/connectAnalytics

    Connect analytics
    OrangeAndGreen authored Aug 3, 2023
    Configuration menu
    Copy the full SHA
    8803140 View commit details
    Browse the repository at this point in the history
  3. Changed SSO token retrieval to a sync process, and calling it asynchr…

    …onously when building HTTP requests.
    OrangeAndGreen committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    ad3aa57 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    154a5be View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    682f3ee View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. make event params unique

    shubham1g5 committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    138f746 View commit details
    Browse the repository at this point in the history
  2. More attempted fixes for earlier Android versions using PIN for biome…

    …tric.
    
    Fixed a crash when SSO failed during sync.
    Fixed a crash after entering alt. OTP during account recovery.
    Changes to when fingerprint and/or PIN options are shown for biometric configuration.
    OrangeAndGreen committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    dfd8fdc View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. Addressed several comments from PR 2660.

    Created a new ConnectIDTask enum to represent possible ConnectID tasks.
    OrangeAndGreen committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    9a46ac9 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Merge pull request #2688 from dimagi/analyticsUniqueParams

    make Connect event params unique
    shubham1g5 authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    6345b66 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Showing a toast when user presses Continue button twice while network…

    … call in progress.
    
    Created ConnectIDTask enum for representing various ConnectID tasks and encapsulate associated activities.
    OrangeAndGreen committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    566078e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f80e233 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. Changes to address PR comments.

    Moved SSO network calls to a dedicated ConnectIDSSOHelper class.
    Converted ConnectIDNetworkHelper to a singleton.
    A couple other small changes.
    OrangeAndGreen committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    f57970a View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. Refactored encryption methods slightly for easier testing.

    Using a common callback converter method in ConnectIDNetworkHelper.
    Not remembering user's reg. info until registration call succeeds.
    OrangeAndGreen committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    6ffa2f6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    63f234d View commit details
    Browse the repository at this point in the history
  3. Applied CommCare coding style to all new ConnectID code.

    Cleaned up a couple code warnings.
    OrangeAndGreen committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    c718bf7 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. Better singleton loading for ConnectIDNetworkHelper.

    Indicating to user when any Connect call fails due to internet connection (i.e. unknown host).
    Converted all Connect URLs to static strings.
    Improved message about attempting to send OTP to user.
    Improved message when user attempts to send a request a second time while first is in progress.
    OrangeAndGreen committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    d4bf1b7 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Addressing comments for PR.

    Checking if ConnectID is unlocked before retrieving SSO token.
    No null check on passphrase when retrieving from global DB.
    OrangeAndGreen committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    525b332 View commit details
    Browse the repository at this point in the history
  2. Tying transformation string to existing key in Keystore (so app can s…

    …till use RSA after upgrading to API >=31).
    OrangeAndGreen committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    d88d97d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    de32648 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Added some missing strings (from conflict).

    Improved EncryptionUtils documentation, fixed a couple lint warnings, and reformatted code.
    Abstracted onFinishProcessing function in ConnectIDNetworkHelper.
    OrangeAndGreen committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    3ca59c3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0661af5 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. Configuration menu
    Copy the full SHA
    bf11aa2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c4eb7bf View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f8724f0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    be096bb View commit details
    Browse the repository at this point in the history
  5. Refactored encryption key code into EncryptionKeyProvider class and e…

    …xposed via CommCareApplication.
    
    Created MockEncryptionKeyProvider to allow encryption without Keystore in tests.
    OrangeAndGreen committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    28c4610 View commit details
    Browse the repository at this point in the history
  6. Assigning default encryptionKeyProvider immediately (child can overri…

    …de later).
    
    Some small code cleanup.
    OrangeAndGreen committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    b3aa48e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5f53442 View commit details
    Browse the repository at this point in the history
  8. Addressing lint warnings.

    Auto-reformatted code in several files.
    Renamed several variables so acronyms use camel-case.
    Broke some longer lines into multiple.
    OrangeAndGreen committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    4bb727e View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    ee16434 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    f548a4a View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    b5b60e7 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Configuration menu
    Copy the full SHA
    d6719e3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8855e6b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6409159 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b8d8997 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    98c0a6f View commit details
    Browse the repository at this point in the history