-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kubernetes): add support to configure control plane firewall #1310
Conversation
5168088
to
8e954c1
Compare
8e954c1
to
e4c76db
Compare
@basert Fabian, Thanks again for a great contribution 🚀 |
Uhh, I don't see any of your suggestions :) Can I see the test results? I only have access to our company DO account and I dont wanna run the tests against that environment. |
@basert Hey Fabio, Sorry, I forgot to complete the review, which caused the comments to remain in the pending stage. I appreciate you bringing this to my attention. You should now be able to see the suggestions.
|
e4c76db
to
d793cd8
Compare
Awesome, thanks for the review, I adjusted the code to your suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome! Thanks for doing an amazing job! 🚀 🦈
caused a bug: #1318 |
This PR allows to configure https://docs.digitalocean.com/products/kubernetes/how-to/add-control-plane-firewall/