Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Work in progress] Table view #63

Open
wants to merge 4 commits into
base: next
Choose a base branch
from

Conversation

dereklieu
Copy link

Syncing my work for the day. I'll pick this up tomorrow. Things left to do:

  • Sorting
  • Having a way to specify which data columns to pull out from the geojson properties object.

Anything else?

@mojodna on that last point, this is just naively taking the first geojson feature from filteredFeatures that has a properties property, and using the keys from that property to determine the table headers. I think it makes sense to pass some sort of configuration, at the very least determining which properties to pick. Otherwise for anything more complicated the table becomes useless.

If we want to avoid passing configuration, an alternative would some UI that lets you control which columns to show. Open to other suggestions as well.

screen shot 2017-06-01 at 7 52 28 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant