Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncing my work for the day. I'll pick this up tomorrow. Things left to do:
Anything else?
@mojodna on that last point, this is just naively taking the first geojson feature from
filteredFeatures
that has aproperties
property, and using the keys from that property to determine the table headers. I think it makes sense to pass some sort of configuration, at the very least determining which properties to pick. Otherwise for anything more complicated the table becomes useless.If we want to avoid passing configuration, an alternative would some UI that lets you control which columns to show. Open to other suggestions as well.