Turn Instantclick into a module if it needs to be one #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Really would love this. I've been using @egoist's fork (https://github.com/egoist/instantclick) just so I can use instantclick without bower. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of web developers use RequireJs, Browserify or the like, so this PR enables Instantclick to be
require-d orimport-ed from Javascript and Typescript entry points.Regular functionality is the same. If the script runs plainly in the browser, it will attach the InstantClick object to
windowas usual.I also added a package.json to let people do
npm install https://github.com/dieulot/instantclickand be on their way.