Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back functionality for bookmark props #2715

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mgmolisani
Copy link

This restores functionality that seemed to have accidentally erased in a minor version update to converge the forked pdfkit vendor package. This resulted in all bookmarks being created in fit mode on the last page not respecting any of the props.

I additionally added some comments to roughly show where the custom logic of this file exists to give some signal that this should not be altered in future fork maintenance.

I tested this locally in a simple repro and observed both the raw output and the PDF in Adobe Reader were again properly linking to the page and respecting props.

There are no unit tests for the custom logic in this vendor package hence I did not add any new ones.

Resolves #2700

Copy link

changeset-bot bot commented Apr 12, 2024

⚠️ No Changeset found

Latest commit: 8048716

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@typesafeui
Copy link
Contributor

Nice! this probably closes #2682 too 🙌

@AgustinBilldin
Copy link

pls merge

@EvHaus
Copy link

EvHaus commented Jun 23, 2024

Confirmed this fixes #2700 for me

@typesafeui
Copy link
Contributor

@diegomura @wojtekmaj can we merge this?

Copy link
Owner

@diegomura diegomura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pushing this. I really need to start using the base pdfkit thought 😞 Do you think you can try finding a way to fix this on react-pdf side?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bookmarks all link to last page in document
5 participants