-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed .yml
build error caused by ternary in script name for e2e-node
#2690
base: master
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: cb53e4e The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I thought this was a simple change because of small syntax error, looks like a can of worms I wasn't ready for 😅 |
Could the E2E tests output be different now that this.bits is correctly being set? |
That does not seem to be the cause, as there are no images involved in the test. The difference seems to be in the encoding of the deflated stream (deflating the streams in reference.pdf and the test output using qpdf results in identical files, excepts for the "moving parts"). This makes me believe that the difference is caused by a change in the output of the zlib compression, rather than by the JPEG fix. |
Duplicate of #2633 |
In response to the above error, which seems to have been triggered after my recent PR merge, I removed the ternary from the name. At a glance, this appears to be for vanity purposes anyway.