Add-scalafix #15
Merged
Add-scalafix #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laderlappen
force-pushed
the
add-scalafix
branch
from
38aae4d
to
71bd4ad
Compare
ff137
reviewed
Dec 7, 2023
ff137
reviewed
Dec 7, 2023
.github/workflows/ci.yml
Outdated
Comment on lines
39
to
40
| - run: sbt "test" | ||
| - run: sbt "scalafix --check OrganizeImports" |
There was a problem hiding this comment.
Nitpick: quotes can be removed
There was a problem hiding this comment.
If I run it without the quotes locally it gives the error:
[error] No rules requested to run
[error] (Compile / scalafix) scalafix.sbt.ScalafixFailed: NoRulesError
[error] Total time: 1 s, completed 07 Dec 2023, 16:30:49
There was a problem hiding this comment.
I could remove the quotes in line 39.
But not for line 40.
ff137
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.