Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade aries-cloudagent to 0.8.1 #11

Merged
merged 15 commits into from
Jul 21, 2023
Merged

Upgrade aries-cloudagent to 0.8.1 #11

merged 15 commits into from
Jul 21, 2023

Conversation

ff137
Copy link
Collaborator

@ff137 ff137 commented Jul 19, 2023

Upgrade docker image + dependency for aries-cloudagent to 0.8.1

Includes upgrades to all dependencies, and minor reformatting. Also some attempts to deduplicate code in the test

@ff137 ff137 self-assigned this Jul 19, 2023
@ff137 ff137 requested a review from lohanspies July 19, 2023 13:30
@ff137
Copy link
Collaborator Author

ff137 commented Jul 19, 2023

@lohanspies Quality Gate is blocking because of code duplication in the test.
I can't reduce duplication any further (it was 30%, now 16%). Threshold seems to be set at 3%, so must've been set after tests were written. Could you increase it to 20% for this project?

@ff137
Copy link
Collaborator Author

ff137 commented Jul 20, 2023

@lohanspies I got this working with 0.8.1 in cloud api: didx-xyz/aries-cloudapi-python#389

Turns out SonarCloud quality gate doesn't block - but I do need review approval please

@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
16.6% 16.6% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@ff137 ff137 requested review from cl0ete and removed request for lohanspies July 21, 2023 08:16
@ff137 ff137 merged commit dc6882a into main Jul 21, 2023
3 of 4 checks passed
@ff137 ff137 deleted the upgrade-0.8.1 branch July 24, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants