-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Legion DPI fix #223
Merged
LexiconCode
merged 22 commits into
dictation-toolbox:develop
from
BazookaMusic:Legion_fix
May 1, 2018
Merged
Legion DPI fix #223
Changes from 5 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
e6bea33
fixed wrong placement of squares when using different DPI scaling value
BazookaMusic 10dce2c
error checking for dpi settings retrieval
BazookaMusic 387b0e0
Added stricter foreground enforcement
BazookaMusic 1359888
removed in stricter foreground enforcement
BazookaMusic 0529b08
fixed error message
BazookaMusic 5479779
simpler way to calculate scaling
BazookaMusic 53cd974
Fixed typo
BazookaMusic 4c01444
also scale coordinates of the monitor
BazookaMusic 953983a
also scale coordinates of the monitor
BazookaMusic 13345f7
Merge branch 'Legion_fix' of https://github.com/gerrish/caster into L…
BazookaMusic fbcd112
changed the way monitor rectangles are retrieved to eliminate the nee…
BazookaMusic a697272
changed the way monitor rectangles are retrieved to eliminate the nee…
BazookaMusic 9d9f1ec
removed useless code
BazookaMusic 4d06b30
fixed height calculation
BazookaMusic 9698b37
fixed conflicts
BazookaMusic 7eb1b36
fixed conflicts
BazookaMusic a7cda84
voice recognition added garbage to comment,fixed
BazookaMusic 9568e48
maximum square width is now relative, depends on resolution
BazookaMusic 79cc762
move the vertical partitions to settings
BazookaMusic 5522202
reverted to dragonfly dependent code, works with danesprite dragonfly
BazookaMusic aa5295d
changed documentation to include DaneSprite fork
BazookaMusic 0ce0449
Added Dane sprite fork installation in the documentation. Also, updat…
BazookaMusic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just thinking about ways I could test this and that made me wonder if there is any software that could fake it on my current hardware. In order to keep the simulated resolution high enough to be usable it wouldn't necessarily scale at the same rates horizontally and vertically. It could also have weird DPI values.
What if a piece of hardware doesn't have square pixels? Also, wouldn't it be easier/faster to just divide the given DPI value by 96.0?