Fix events teleporting around with fast mouse clicks #2454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Looks reasonable to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered an issue where events would randomly teleport in the visual timeline when clicking too fast for the
_processfunction to run. Additionally, sometimes the mouse position would be in the dead space between events causingdrag_to_positionnot to get updated when_processdid get called.This fix ensures that
drag_to_positionhas been updated at least once after starting a drag operation, otherwise cancels the drag on completion.This was a pretty difficult bug to reproduce on my machine, but my tester has a very fast click and could consistently reproduce the issue, to the point where their timeline constantly was getting garbled.