Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle some null/freed item cases to avoid bugs #2432

Conversation

Invertex
Copy link
Contributor

May fix #2381 but don't know for sure yet.

Regardless, this gets rid of some potential error spam that isn't useful to the end-user.

Sometimes the opener_events_stack items can be in the process of being freed, or have become Null by the time the code got there and causes an error trying to feed them into the create_and_branch_event() function.
Same with the _batches content.

@Jowan-Spooner Jowan-Spooner added the Approved This can be added, but is not on any roadmap yet label Oct 15, 2024
@Jowan-Spooner
Copy link
Member

Looks good generally, some testing would be nice.

@zaknafean zaknafean self-requested a review October 16, 2024 19:39
Copy link
Collaborator

@zaknafean zaknafean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this does no harm and likely does fix some issues some people see, though I can't recreate the issues this was supposed to address consistently. My concern is this may be more a bandage to a core problem. But it isn't enough of a problem in my eyes to not merge up.

@zaknafean zaknafean merged commit f27d079 into dialogic-godot:main Oct 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved This can be added, but is not on any roadmap yet
Development

Successfully merging this pull request may close these issues.

Timelines will save over each other
3 participants