Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Choices: add array boundary checking #2428

Closed
wants to merge 0 commits into from
Closed

Choices: add array boundary checking #2428

wants to merge 0 commits into from

Conversation

endaye
Copy link
Contributor

@endaye endaye commented Oct 6, 2024 •
edited
Loading

  • to fix this bug below
image

@Jowan-Spooner
Copy link
Member

This looks alright, but it fixes a symptom, I'd be really curious why this happens.

@Jowan-Spooner Jowan-Spooner added the Approved This can be added, but is not on any roadmap yet label Oct 15, 2024
@endaye
Copy link
Contributor Author

endaye commented Oct 16, 2024

I am not sure. Maybe it was caused by what I called Dialogic.clear() when it's running.

@zaknafean
Copy link
Collaborator

Does that cause it to happen consistently? Can you share the code?

@zaknafean zaknafean self-requested a review October 16, 2024 20:51
zaknafean
zaknafean requested changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@zaknafean zaknafean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I generally like bounds checking, this feels like a bandage to a problem that maybe shouldn't exist. We really need an example of when this happens here specifically, and why. Do you have a small project we could review?

@endaye endaye closed this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaknafean zaknafean zaknafean requested changes

Assignees
No one assigned
Labels
Approved This can be added, but is not on any roadmap yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@endaye @Jowan-Spooner @zaknafean