Avoid null get_tree() call #2052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_tree() can return null when the Dialogic view isn't open but this function is being called by an external system. No node tree exists to wait for or manipulate, so errors are spammed.
|
Thanks, LGTM. |
Invertex
added a commit
to Invertex/dialogic
that referenced
this pull request
Jan 27, 2024
commit 17683f8 Author: Jowan-Spooner <[email protected]> Date: Fri Jan 26 18:55:38 2024 +0100 Rename the Other folder to Core (dialogic-godot#2047) * Rename the Other folder to Core * Add a small auto-update * Fix unit test commit ce2a734 Author: Jowan-Spooner <[email protected]> Date: Fri Jan 26 18:55:03 2024 +0100 Allow specifying parent to add layout (dialogic-godot#2048) - fixes dialogic-godot#2029 commit c33a560 Author: Dabbles in too many things <[email protected]> Date: Fri Jan 26 09:54:52 2024 -0800 Avoid null get_tree() call (dialogic-godot#2052) get_tree() can return null when the Dialogic view isn't open but this function is being called by an external system. No node tree exists to wait for or manipulate, so errors are spammed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_tree() can return null when the Dialogic view isn't open but this function is being called by an external system. No node tree exists to wait for or manipulate, so errors are spammed.