Skip to content

Commit

Permalink
Add voice previews, fix some code style
Browse files Browse the repository at this point in the history
  • Loading branch information
salianifo committed Oct 18, 2024
1 parent 9631ef4 commit 8408422
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 4 deletions.
2 changes: 0 additions & 2 deletions addons/dialogic/Modules/Audio/event_music.gd
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ func get_channel_list() -> Array:
return channel_name_list



func _on_play_preview_audio() -> void:
if _preview_node:
_preview_node.stream = load(file_path)
Expand All @@ -126,4 +125,3 @@ func _on_stop_preview_audio() -> void:

func _on_preview_finished() -> void:
ui_update_needed.emit()

4 changes: 2 additions & 2 deletions addons/dialogic/Modules/Audio/event_sound.gd
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@ func get_shortcode_parameters() -> Dictionary:
################################################################################

func build_event_editor() -> void:
add_header_edit('file_path', ValueType.FILE,
{'left_text' : 'Play',
add_header_edit('file_path', ValueType.FILE, {
'left_text' : 'Play',
'file_filter' : '*.mp3, *.ogg, *.wav; Supported Audio Files',
'placeholder' : "Select file",
'editor_icon' : ["AudioStreamPlayer", "EditorIcons"]})
Expand Down
26 changes: 26 additions & 0 deletions addons/dialogic/Modules/Voice/event_voice.gd
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ var volume: float = 0
var audio_bus := "Master"


var _preview_node: AudioStreamPlayer

################################################################################
## EXECUTE
################################################################################
Expand Down Expand Up @@ -45,6 +47,11 @@ func _init() -> void:
event_sorting_index = 5


func _enter_visual_editor(_timeline_editor:DialogicEditor) -> void:
_preview_node = AudioStreamPlayer.new()
editor_node.add_child(_preview_node)
_preview_node.finished.connect(_on_preview_finished)

################################################################################
## SAVING/LOADING
################################################################################
Expand Down Expand Up @@ -73,5 +80,24 @@ func build_event_editor() -> void:
'file_filter' : "*.mp3, *.ogg, *.wav",
'placeholder' : "Select file",
'editor_icon' : ["AudioStreamPlayer", "EditorIcons"]})
add_header_button('', _on_play_preview_audio, '', ["Play", "EditorIcons"], '!file_path.is_empty() && !_preview_node.is_playing()')
add_header_button('', _on_stop_preview_audio, '', ["Stop", "EditorIcons"], '_preview_node.is_playing()')
add_body_edit('volume', ValueType.NUMBER, {'left_text':'Volume:', 'mode':2}, '!file_path.is_empty()')
add_body_edit('audio_bus', ValueType.SINGLELINE_TEXT, {'left_text':'Audio Bus:'}, '!file_path.is_empty()')


func _on_play_preview_audio() -> void:
if _preview_node:
_preview_node.stream = load(file_path)
_preview_node.play()
ui_update_needed.emit()


func _on_stop_preview_audio() -> void:
_preview_node.stop()
_preview_node.stream = null
ui_update_needed.emit()


func _on_preview_finished() -> void:
ui_update_needed.emit()

0 comments on commit 8408422

Please sign in to comment.