Skip to content

Commit

Permalink
Remove commented code, typo
Browse files Browse the repository at this point in the history
  • Loading branch information
salianifo committed Oct 6, 2024
1 parent b381177 commit 1ee83f8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 21 deletions.
19 changes: 1 addition & 18 deletions addons/dialogic/Modules/Audio/event_music.gd
Original file line number Diff line number Diff line change
Expand Up @@ -76,24 +76,7 @@ func build_event_editor() -> void:
'file_filter' : "*.mp3, *.ogg, *.wav; Supported Audio Files",
'placeholder' : "No music",
'editor_icon' : ["AudioStreamPlayer", "EditorIcons"]})
add_header_edit('channel_id', ValueType.FIXED_OPTIONS, {'left_text':'on:', 'options': get_channel_list()})#[
#{
#'label': 'Channel A',
#'value': 0,
#},
#{
#'label': 'Channel B',
#'value': 1,
#},
#{
#'label': 'Channel C',
#'value': 2,
#},
#{
#'label': 'Channel D',
#'value': 3,
#}
#]})
add_header_edit('channel_id', ValueType.FIXED_OPTIONS, {'left_text':'on:', 'options': get_channel_list()})
add_body_edit('fade_length', ValueType.NUMBER, {'left_text':'Fade Time:'})
add_body_edit('volume', ValueType.NUMBER, {'left_text':'Volume:', 'mode':2}, '!file_path.is_empty()')
add_body_edit('audio_bus', ValueType.SINGLELINE_TEXT, {'left_text':'Audio Bus:'}, '!file_path.is_empty()')
Expand Down
4 changes: 1 addition & 3 deletions addons/dialogic/Modules/Audio/subsystem_audio.gd
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ extends DialogicSubsystem
## `volume` | [type float] | The volume of the audio resource that will be set to the [member base_music_player]. [br]
## `audio_bus` | [type String] | The audio bus name that the [member base_music_player] will use. [br]
## `loop` | [type bool] | Whether the audio resource will loop or not once it finishes playing. [br]
## `channel` | [type int] | The channel id to play the audio on. [br]
## `channel` | [type int] | The channel ID to play the audio on. [br]
signal music_started(info: Dictionary)


Expand All @@ -31,8 +31,6 @@ signal music_started(info: Dictionary)
signal sound_started(info: Dictionary)


#const MAX_CHANNELS = 6

var max_channels: int:
set(value):
if max_channels != value:
Expand Down

0 comments on commit 1ee83f8

Please sign in to comment.