Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EmailValidator #73

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add EmailValidator #73

wants to merge 3 commits into from

Conversation

simo97
Copy link
Contributor

@simo97 simo97 commented Jun 8, 2020

This PR extend default validators by adding EmailValidator. It is usable in the same way as the other one.

To validate if a field is and email or not
EmailValidator added to validators
@di
Copy link
Owner

di commented Jun 8, 2020

Thanks for the PR! Validating emails is notoriously challenging. Instead of using our own regex, this should probably use https://pypi.org/project/email-validator/ instead.

@simo97
Copy link
Contributor Author

simo97 commented Jun 9, 2020

Yeah i took that one in a package (maybe django itself or another one) but i will update it with yours. And correct the tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants