feat: Add embedded properties to Dashboard [DHIS2-18239] #18843
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larshelge
changed the title
larshelge
changed the title
larshelge
changed the title
dhis-2/dhis-api/src/main/java/org/hisp/dhis/dashboard/Dashboard.java
Outdated
Show resolved
Hide resolved
gnespolino
approved these changes
Oct 23, 2024
maikelarabori
approved these changes
Oct 25, 2024
|
|
I moved this PR to a new one due to the signed commit requirement in master. |
|
Merged the new PR now. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a object
EmbeddedDashboardproperties to theDashboardentity meant to represent an embedded dashboard.providerrefers to the provider of embedded dashboards, and can be extended to Power BI, Tableau and the like later.idrefers to the identifier of the embedded dashboard defined by the external provider.optionsrefers to customization options from the embedded dashboard provider, and can be extended later.Adds a system setting for enabling Superset embedded dashboards.