Packages created in the standard Cmake format rather than previous depreciated Python format #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there!
Thank you for the amazing repo you have made, its a good start to creating urdf packages for ros2
However, the current package creation in your repo involves the usage of python which is a depreciated format. Moreover, the launch files too can be made more effective and useful. I have made the necessary changes to get the files in Cmake format and also made changes in launch files. I request you to test these codes once and if looks good, merge it to the main branch. This way a lot of developers will get to utilize the updated version
Thanks and cheers!