Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to Schedule Page #439

Merged
merged 1 commit into from
Oct 26, 2024
Merged

Conversation

manya1632
Copy link
Contributor

@manya1632 manya1632 commented Oct 26, 2024

Pull Request Template for GSoC 2024 && Hacktoberfest 2024

Related Issue

#433
closes:

Description of Changes

I have used an api to fetch the schedule of train if the train number is entered
API used : http://indianrailapi.com/api/v2/TrainSchedule/apikey//TrainNumber//

one just needs to modify the code by adding their indian rail api key after login in to the website https://indianrailapi.com/api-collection/train-schedule

Type of Pull Request

  • Bug Fix
  • New Feature
  • Performance Improvement
  • Documentation Update
  • Code Refactoring
  • Security Enhancement
  • Other (Specify): Backend Issue

Screenshots / Demo (if applicable)

Screenshot 2024-10-26 164448

Checklist for Contributor

use'X' in [ ] to check it .

  • I have reviewed my code before submission.
  • I have read and followed the project's Contribution Guidelines.
  • I have tested the code thoroughly.
  • I have attached related issue numbers, screenshots, or videos (if applicable).
  • I have added comments to my code where necessary for clarity.
  • I have checked the existing code base and my changes do not introduce any breaking changes.
  • My PR addresses only one issue; I have created separate PRs for other issues.
  • I have ensured that the PR does not include unrelated files.
  • I am mindful of the project's coding standards and best practices.

Additional Information

The user needs to enter their API key after login in Indian Rail api websitye

Contribution Guidelines Reminder

Thank you for contributing to our project! Please ensure you follow the guidelines below:

Contribution Levels

  1. Task Categories:

    • Basic Tasks: Primarily focused on small changes like minor bug fixes, documentation improvements, and unit testing. Labeled as Easy.
    • Intermediate Tasks: Moderate-level tasks that involve enhancing existing features, code refactoring, or performance improvements. Labeled as Medium.
    • Advanced Tasks: Complex tasks like building new features, significant refactoring, or critical bug fixes. Labeled as Hard.
  2. Acknowledging Effort:

    • Exceptional contributions will be recognized with a higher contribution level if substantial effort and innovation are demonstrated.

Review Process

  • PRs will be reviewed by the maintainers, and feedback will be provided. Contributors should address feedback promptly and resubmit the PR if necessary.

  • Contributors are encouraged to participate in the review process of other PRs for community growth.

We appreciate your time and effort in improving this project and look forward to your valuable contributions!

Copy link

vercel bot commented Oct 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
station-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2024 11:18am
station-guide-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2024 11:18am

Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@manya1632
Copy link
Contributor Author

Please look and resolve this
Screenshot 2024-10-26 220140

@dhairyagothi
Copy link
Owner

Please look and resolve this Screenshot 2024-10-26 220140

this will be done after PR merge

@dhairyagothi
Copy link
Owner

@manya1632 can you please tell how to get api key ??

@dhairyagothi dhairyagothi added enhancement New feature or request level 2 25 Points Issue gssoc-ext GSSOX'24 Extended hacktoberfest-accepted Hacktoberfest hacktoberfest issue under hacktoberfest labels Oct 26, 2024
@dhairyagothi dhairyagothi merged commit e29fc0f into dhairyagothi:main Oct 26, 2024
5 checks passed
Copy link
Contributor

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to Station Guide. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

@dhairyagothi
Copy link
Owner

closes : #433

@manya1632
Copy link
Contributor Author

Yes sure !
To get the API key , first go to this website https://indianrailapi.com/api-collection and sign up yourself , enter details and then you go the verification part, where you need to enter the email and the verification code sent to that email you entered at the first place, then again you need to login yourself with the username and password sent to your email. Here you're logged in . At your left hand side you can see the API key section which contains your api .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc-ext GSSOX'24 Extended hacktoberfest issue under hacktoberfest hacktoberfest-accepted Hacktoberfest level 2 25 Points Issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants